Skip to content

Conversation

benma
Copy link
Collaborator

@benma benma commented Oct 4, 2025

Builds on #1619

@benma benma force-pushed the unlock-reduce-sc-events branch 3 times, most recently from 7cd4971 to a670560 Compare October 9, 2025 18:21
@benma benma marked this pull request as ready for review October 9, 2025 19:50
@benma benma requested a review from NickeZ October 9, 2025 19:50
@benma benma force-pushed the unlock-reduce-sc-events branch 2 times, most recently from 99a857e to e248ab2 Compare October 12, 2025 18:30
Copy link
Collaborator

@NickeZ NickeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

benma added 3 commits October 13, 2025 09:23
Every call to `keystore::unlock` is followed by `copy_seed()`. The latter
uses a secure chip operation. We can remove that by returning the seed
from unlock and re-using it.

This reduces the number of securechip operations by 1 when:

- when unlocking the device
- showing mnemonic on initialized device
- creating backu on initialized device

This is to reduce the risk of running into Optiga's throttling
security mechanism.
@benma benma force-pushed the unlock-reduce-sc-events branch from e248ab2 to e6d8560 Compare October 13, 2025 07:27
@benma benma merged commit 7363fde into BitBoxSwiss:master Oct 13, 2025
33 checks passed
@benma benma deleted the unlock-reduce-sc-events branch October 13, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants